Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lua optional #86

Closed
LoganDark opened this issue Jan 6, 2022 · 4 comments
Closed

Make Lua optional #86

LoganDark opened this issue Jan 6, 2022 · 4 comments
Milestone

Comments

@LoganDark
Copy link
Contributor

Including Lua is wasted space when it's not used, please put it behind a Cargo feature (even if that's enabled by default). Honestly most of the crate should be behind cargo features.

@fenollp
Copy link
Collaborator

fenollp commented Jan 6, 2022

Hi @LoganDark thanks for raising this.
We appreciate your comment and welcome discussion. cc at #55

Can you tell us a bit more about how you're using libremarkable?

What other parts of the crate do you feel should be behind features?

@LoganDark
Copy link
Contributor Author

Can you tell us a bit more about how you're using libremarkable?

I'm going to use libremarkable in 2 programs that are designed to work together:

  • An application that the user runs to input calibration data. This will require the GUI stuff, but not Lua
  • A shared object that intercepts xochitl's pen events, ReCept-style. This does NOT require the GUI stuff, only the input device scanning (so I know which /dev/input/eventX is the wacom digitizer)

In the former case I need the entire application system, input event handling and all. But in the latter case I only need a small subset of libremarkable.

@bkirwi
Copy link
Collaborator

bkirwi commented Jan 6, 2022

Yeah, I think this use case is addressed by #55. (Which we don't have an issue for yet, so might as well keep this one open.)

It's worth mentioning that appctx is not very heavily used, compared to the rest of the library. Many libremarkable users end up using the low-level device support and handrolling a toolkit suited to the needs of their app. If you're not happy with how appctx works, that's a good way to keep yourself unblocked! (Though we should follow through on #55 regardless to keep builds lighter.)

@bkirwi
Copy link
Collaborator

bkirwi commented Jan 14, 2022

#55 is merged, so I'll mark this done. We should have a proper release out soon within the next week or two I imagine...

@bkirwi bkirwi closed this as completed Jan 14, 2022
@LinusCDE LinusCDE added this to the 0.6.0 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants