-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Lua optional #86
Comments
Hi @LoganDark thanks for raising this. Can you tell us a bit more about how you're using libremarkable? What other parts of the crate do you feel should be behind features? |
I'm going to use libremarkable in 2 programs that are designed to work together:
In the former case I need the entire application system, input event handling and all. But in the latter case I only need a small subset of libremarkable. |
Yeah, I think this use case is addressed by #55. (Which we don't have an issue for yet, so might as well keep this one open.) It's worth mentioning that |
#55 is merged, so I'll mark this done. We should have a proper release out soon within the next week or two I imagine... |
Including Lua is wasted space when it's not used, please put it behind a Cargo feature (even if that's enabled by default). Honestly most of the crate should be behind cargo features.
The text was updated successfully, but these errors were encountered: