Fix 404 error #17
Merged
Fix 404 error #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
suggested changes
Mar 16, 2018
DeployClient/Program.cs
Outdated
| TimeSpan interval = new TimeSpan(0, 0, 0, 2); | ||
| Dictionary<string, dynamic> response; | ||
| var successfullyReachedApi = false; | ||
| DateTime apiNotFoundAbortTime = DateTime.Now.AddSeconds(Options.InstallationStatusTimeout?? 60); |
There was a problem hiding this comment.
Can we please improve the whitespace formatting around the null conditional operator.
DeployClient/Program.cs
Outdated
| // The api should not be returning a 404 status at this point | ||
| if (!success) | ||
| { | ||
| throw new Exception("Remote API returned status 404"); |
There was a problem hiding this comment.
Please can we throw something more specific than System.Exception. It's bad practise to throw these. I think System.Web.HttpException would be more appropriate instead.
ghost
approved these changes
Mar 16, 2018
ghost
approved these changes
May 8, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to how checking the installation status works after starting an installation. Currently, on large installations, it can attempt to get the status before the web api has been fully created.
Api.GetSession(). If the time limit is reached, then abort from the process. If it successfully manages to connect with the api before that time, then carry on as usual