Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catches the TZInfo::PeriodNotFound exception and retries the cron for on... #181

Closed
wants to merge 1 commit into from

Conversation

snicker
Copy link
Contributor

@snicker snicker commented Mar 8, 2014

...e hour in the future and also changes the periodic cleanup to 11:59PM

This needs some refactoring, but a ruby wizard I am not. maybe move that block into it's own method?

… one hour in the future and also changes the periodic cleanup to 11:59PM
@snicker
Copy link
Contributor Author

snicker commented Mar 8, 2014

fix for #180

@cantino
Copy link
Member

cantino commented Mar 9, 2014

Interesting, so shifting it an hour fixes it for you?

@snicker
Copy link
Contributor Author

snicker commented Mar 9, 2014

Yup, that was the recommendation. TZInfo throws two diff exceptions,
there's probably another that needs to be monitored for "falling back"

On Mar 8, 2014, at 18:06, Andrew Cantino notifications@github.com wrote:

Interesting, so shifting it an hour fixes it for you?

@cantino
Copy link
Member

cantino commented Mar 9, 2014

But do we need to restore to the normal schedule in a day or two?

On Saturday, March 8, 2014, snicker notifications@github.com wrote:

Yup, that was the recommendation. TZInfo throws two diff exceptions,
there's probably another that needs to be monitored for "falling back"

On Mar 8, 2014, at 18:06, Andrew Cantino <notifications@github.comjavascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

Interesting, so shifting it an hour fixes it for you?

Reply to this email directly or view it on
GitHubhttps://github.com//pull/181#issuecomment-37116710
.

Reply to this email directly or view it on GitHubhttps://github.com//pull/181#issuecomment-37117030
.

@snicker
Copy link
Contributor Author

snicker commented Mar 9, 2014

I think that the cleanup can probably be reset to midnight... That
shouldn't ever lay between 1 and 2am (the problem hour)... It was one of
the squashed commits when I was testing. But why not 11:59pm because "think
different" Or whatever?

The hourly schedules will only go into effect if the exception is thrown
which would only happen one day of the year

@cantino
Copy link
Member

cantino commented Mar 9, 2014

Yea, I'm fine with the minutes change. I was wondering if the hourly
schedules should get reset the day after the time change, so that they
don't stay shifted for weeks until the Huginn instance is restarted.

On Saturday, March 8, 2014, snicker notifications@github.com wrote:

I think that the cleanup can probably be reset to midnight... That
shouldn't ever lay between 1 and 2am (the problem hour)... It was one of
the squashed commits when I was testing. But why not 11:59pm because "think
different" Or whatever?

The hourly schedules will only go into effect if the exception is thrown
which would only happen one day of the year

On Mar 8, 2014, at 18:26, Andrew Cantino <notifications@github.comjavascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

But do we need to restore to the normal schedule in a day or two?

On Saturday, March 8, 2014, snicker <notifications@github.comjavascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

Yup, that was the recommendation. TZInfo throws two diff exceptions,
there's probably another that needs to be monitored for "falling back"

On Mar 8, 2014, at 18:06, Andrew Cantino <notifications@github.comjavascript:_e(%7B%7D,'cvml','notifications@github.com');
<javascript:_e(%7B%7D,'cvml','notifications@github.comjavascript:_e(%7B%7D,'cvml','notifications@github.com');
');>>
wrote:

Interesting, so shifting it an hour fixes it for you?

Reply to this email directly or view it on
GitHubhttps://github.com//pull/181#issuecomment-37116710
.

Reply to this email directly or view it on GitHub<
https://github.com/cantino/huginn/pull/181#issuecomment-37117030>
.

Reply to this email directly or view it on
GitHubhttps://github.com//pull/181#issuecomment-37117062
.

Reply to this email directly or view it on GitHubhttps://github.com//pull/181#issuecomment-37119077
.

@snicker
Copy link
Contributor Author

snicker commented Mar 9, 2014

Ahh, I see.

I erroneously assumed that it would work itself out, but the application
would have to be restarted for that to happen.

I originally thought that the correction of such an error would really fall
in the scope of rufus-scheduler, and this is really more of a workaround.
You could implement a schedule to remove these schedules 24h later and
straighten it out...

@cantino
Copy link
Member

cantino commented Mar 9, 2014

At least on my system, everything is working okay now. We should still fix this for next year, but there's no rush. I'll look at this shortly :)

@0xdevalias
Copy link
Member

Ping @cantino

@cantino
Copy link
Member

cantino commented Jul 4, 2014

Should be fixed by rufus-scheduler update: https://github.com/jmettraux/rufus-scheduler/blob/master/CHANGELOG.txt

@cantino cantino closed this Jul 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants