Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for writing Capybara specs #1275

Merged
merged 2 commits into from Feb 8, 2016
Merged

Conversation

TildeWill
Copy link
Contributor

  • uses headless browser via phantomjs/poltergeist
  • includes an example spec for creating an Agent
  • includes a helper for interacting with Select2 boxes

Additionally, having Capybara will be helpful for my work with Omniscope as I add specs to give me confidence users can manage their billing flows correctly.

- uses headless browser via phantomjs/poltergeist
- includes an example spec for creating an Agent
- includes a helper for interacting with Select2 boxes
@cantino
Copy link
Member

cantino commented Feb 6, 2016

Nice! This is a good improvement. Let me know when it's ready to merge.

@TildeWill
Copy link
Contributor Author

Should be good to go now that the tests have passed on Travis

@cantino
Copy link
Member

cantino commented Feb 6, 2016

My only concern is if people developing Agents will have trouble getting phantomjs/poltergeist working. Is it pretty easy to install on Mac and Linux?

@TildeWill
Copy link
Contributor Author

TravisCI has phantomjs installed by default. npm install phantomjs worked on my Linux environment (Cloud9), and brew install phantomjs has always been straight forward for me on a Mac. Is there a place in the README/Wiki about test writing/running that would benefit from added documentation?

@cantino
Copy link
Member

cantino commented Feb 7, 2016

There isn't, but I think there should be. Would you be up for adding it, either to the README, or on the wiki?

@TildeWill
Copy link
Contributor Author

Will do

@TildeWill
Copy link
Contributor Author

Documentation added

@@ -648,4 +671,4 @@ DEPENDENCIES
xmpp4r (~> 0.5.6)

BUNDLED WITH
1.10.6
1.11.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this affect people with older Bundler versions? I'm not entirely clear on how "BUNDLED WITH" works or what it does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler spits out a warning when using an older version. Worst case scenario is that devs need to update their version of bundler to suppress the warning which is probably a good thing anyway.

cantino added a commit that referenced this pull request Feb 8, 2016
Adds support for writing Capybara specs
@cantino cantino merged commit 068a0be into huginn:master Feb 8, 2016
@cantino
Copy link
Member

cantino commented Feb 8, 2016

Looks great, thanks @TildeWill!

@TildeWill TildeWill deleted the capybara branch May 18, 2016 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants