New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for writing Capybara specs #1275
Conversation
- uses headless browser via phantomjs/poltergeist - includes an example spec for creating an Agent - includes a helper for interacting with Select2 boxes
Nice! This is a good improvement. Let me know when it's ready to merge. |
Should be good to go now that the tests have passed on Travis |
My only concern is if people developing Agents will have trouble getting phantomjs/poltergeist working. Is it pretty easy to install on Mac and Linux? |
TravisCI has phantomjs installed by default. |
There isn't, but I think there should be. Would you be up for adding it, either to the README, or on the wiki? |
Will do |
Documentation added |
@@ -648,4 +671,4 @@ DEPENDENCIES | |||
xmpp4r (~> 0.5.6) | |||
|
|||
BUNDLED WITH | |||
1.10.6 | |||
1.11.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this affect people with older Bundler versions? I'm not entirely clear on how "BUNDLED WITH" works or what it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundler spits out a warning when using an older version. Worst case scenario is that devs need to update their version of bundler to suppress the warning which is probably a good thing anyway.
Adds support for writing Capybara specs
Looks great, thanks @TildeWill! |
Additionally, having Capybara will be helpful for my work with Omniscope as I add specs to give me confidence users can manage their billing flows correctly.