Agent for Boxcar.io

[prathyush]

New agent to send Boxcar notifications to iOS devices.

[cantino]

Cool @prathyush! Would you be up for adding some RSpec specs to this as well?

[prathyush]

@cantino: I haven't written a spec before but I gave a shot at. However, I couldn't quite get to mock/stub HTTParty.post and check if the event is getting generated. Can you take a look at the spec and see if I'm missing anything obvious?

[prathyush]

The rspec run failed on Ruby 2.1.5 and Postgresql with the following error:

Failures:

  1) DotHelper with example Agents #agents_dot generates a DOT script
     Failure/Error: expect(agents_dot(@agents)).to match(%r{
       expected "digraph \"Agent Event Flow\"{node[shape=box,style=rounded,target=_blank,fontsize=10];edge[fontsize=10];a1061892863[label=foo];a1061892863->a1061892865[color=\"#999999\"];a1061892863->a1061892864[style=dashed];a1061892864[label=bar1];a1061892865[label=bar2,style=\"rounded,dashed\",color=\"#999999\",fontcolor=\"#999999\"];a1061892865->a1061892866[style=dashed,color=\"#999999\"];a1061892866[label=bar3];}" to match /
                 \A
                 digraph \x20 "Agent \x20 Event \x20 Flow" \{
                   node \[ [^\]]+ \];
                   edge \[ [^\]]+ \];
                   (?<foo>\w+) \[label=foo\];
                   \k<foo> -> (?<bar1>\w+) \[style=dashed\];
                   \k<foo> -> (?<bar2>\w+) \[color="\#999999"\];
                   \k<bar1> \[label=bar1\];
                   \k<bar2> \[label=bar2,style="rounded,dashed",color="\#999999",fontcolor="\#999999"\];
                   \k<bar2> -> (?<bar3>\w+) \[style=dashed,color="\#999999"\];
                   \k<bar3> \[label=bar3\];
                 \}
                 \z
               /x
       Diff:
       @@ -1,16 +1,2 @@
       -/
       -          \A
       -          digraph \x20 "Agent \x20 Event \x20 Flow" \{
       -            node \[ [^\]]+ \];
       -            edge \[ [^\]]+ \];
       -            (?<foo>\w+) \[label=foo\];
       -            \k<foo> -> (?<bar1>\w+) \[style=dashed\];
       -            \k<foo> -> (?<bar2>\w+) \[color="\#999999"\];
       -            \k<bar1> \[label=bar1\];
       -            \k<bar2> \[label=bar2,style="rounded,dashed",color="\#999999",fontcolor="\#999999"\];
       -            \k<bar2> -> (?<bar3>\w+) \[style=dashed,color="\#999999"\];
       -            \k<bar3> \[label=bar3\];
       -          \}
       -          \z
       -        /x
       +"digraph \"Agent Event Flow\"{node[shape=box,style=rounded,target=_blank,fontsize=10];edge[fontsize=10];a1061892863[label=foo];a1061892863->a1061892865[color=\"#999999\"];a1061892863->a1061892864[style=dashed];a1061892864[label=bar1];a1061892865[label=bar2,style=\"rounded,dashed\",color=\"#999999\",fontcolor=\"#999999\"];a1061892865->a1061892866[style=dashed,color=\"#999999\"];a1061892866[label=bar3];}"
     # ./spec/helpers/dot_helper_spec.rb:57:in `block (4 levels) in <top (required)>'

Not sure how to figure out which part of my diff would have caused this issue.

[dsander]

@prathyush I reran that job, looks like it has just been a random failure.

[prathyush]

@dsander Awesome!.

[cantino]

Let's just do payload_interpolated['user_credentials'] and then change the instructions to

Please provide your access token in the `user_credentials` option. If you'd like to use a credential, set the `user_credentials` option to `{% credential CREDENTIAL_NAME %}`.

[cantino]

Left some suggestions @prathyush, thanks!

[prathyush]

@cantino Made the changes. Please take a look.

[cantino]

Does this spec fail if you break the code? I think you may need mock here so that an expectation is set.

[prathyush]

Yeah, it fails. I even found a bug (typo) when I first ran this.

[cantino]

Looks good, thanks for the contribution!