Add initializer which sets the TZ environment variable #1356
Conversation
This properly propagates the configured TIMEZONE to the system TZ variable which is used by libv8 in the JavascriptAgent to access the current time.
| @@ -0,0 +1,2 @@ | |||
| # Set the timezone for the JavascriptAgent (libv8 only relies on the TZ variable) | |||
| ENV['TZ'] = Time.zone.tzinfo.canonical_identifier | |||
There was a problem hiding this comment.
Not sure, shouldn't the TIMEZONE .env setting be the only source for the timezone Huginn uses?
There was a problem hiding this comment.
I guess? I know many systems also set TZ, so it might be nice to use if
present? I'm not sure.
On Wed, Mar 16, 2016 at 1:29 AM Dominik Sander notifications@github.com
wrote:
In config/initializers/timezone.rb
#1356 (comment):@@ -0,0 +1,2 @@
+# Set the timezone for the JavascriptAgent (libv8 only relies on the TZ variable)
+ENV['TZ'] = Time.zone.tzinfo.canonical_identifierNot sure, shouldn't the TIMEZONE .env setting be the only source for the
timezone Huginn uses?—
You are receiving this because you commented.Reply to this email directly or view it on GitHub
https://github.com/cantino/huginn/pull/1356/files/c48ff63e7a96260540f9399201cbd7a23d65c9fa#r56296774
There was a problem hiding this comment.
My thought was to use the TIMEZONE .env variable as truth for the timezone the user selects. If we would callback to the system wide TZ when it's present, the only way to have a consistent timezone setting would be to add TZ to .env as well.
There was a problem hiding this comment.
I support that, let's leave this as you have it. LGTM!
On Wed, Mar 16, 2016 at 9:40 AM Dominik Sander notifications@github.com
wrote:
In config/initializers/timezone.rb
#1356 (comment):@@ -0,0 +1,2 @@
+# Set the timezone for the JavascriptAgent (libv8 only relies on the TZ variable)
+ENV['TZ'] = Time.zone.tzinfo.canonical_identifierMy thought was to use the TIMEZONE .env variable as truth for the
timezone the user selects. If we would callback to the system wide TZ
when it's present, the only way to have a consistent timezone setting would
be to add TZ to .env as well.—
You are receiving this because you commented.Reply to this email directly or view it on GitHub
https://github.com/cantino/huginn/pull/1356/files/c48ff63e7a96260540f9399201cbd7a23d65c9fa#r56368208
Add initializer which sets the TZ environment variable
This properly propagates the configured TIMEZONE to the system TZ variable which is used by libv8 in the JavascriptAgent to access the current time.
#1355