Show Dry Run Result with tabs #1371
Conversation
|
Nice, I like it! Not sure about the order of the tabs though, wouldn't one want to look at the generated events first and switch to the log only if something went wrong? |
|
Cool, looks good! I'd agree with @dsander about the order. When I implemented it I thought the log should be the main content when everything was to be shown in one page, but once separated, created events should probably be in the primary tab because they are the main effect of a run. |
|
@thiagotalma I think it is a good idea to remove the timestamps. |
|
I think elapsed times in second precision would be great. |
|
And it could be a separate PR. |
| """, | ||
| body: (body) -> | ||
| $(body). | ||
| find('.agent-dry-run-log').text(json.log).end(). | ||
| find('.agent-dry-run-events').text(json.events).end(). | ||
| find('.agent-dry-run-memory').text(json.memory) | ||
| active = if json.events.match(/^\[?\s*\]?$/) then 'tabLog' else 'tabEvents' |
There was a problem hiding this comment.
Defines the tab will be activated according to checking whether the events are empty. If empty, the Logs tab is activated.
|
Nice improvement! |
|
Looks good to me, thanks! Merging. |
For better organization and viewing the results.
