Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added round trip option to google flight agent #1384

Merged
merged 2 commits into from Mar 30, 2016
Merged

Conversation

Jngai
Copy link
Contributor

@Jngai Jngai commented Mar 28, 2016

No description provided.

@Jngai
Copy link
Contributor Author

Jngai commented Mar 28, 2016

@cantino here is an extra option for round trip airfare.

@Jngai
Copy link
Contributor Author

Jngai commented Mar 28, 2016

I tried this locally.

@@ -16,7 +16,9 @@ class GoogleFlightsAgent < Agent

All the default options must exist. For `infantInSeatCount`, `infantInLapCount`, `seniorCount`, and `childCount`, leave them to the default value of `0` if its not necessary.

Make sure `date` is in this type of date format `YYYY-MO-DAY`.
Make sure `date` and `returned_date` is in this type of date format `YYYY-MO-DAY`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe YYYY-MM-DD?

"Make sure date and returned_date are in the format YYYY-MM-DD."

@Jngai
Copy link
Contributor Author

Jngai commented Mar 29, 2016

@cantino I changed them.

@Jngai
Copy link
Contributor Author

Jngai commented Mar 29, 2016

@Pcsl this will be merged in soon.

@cantino
Copy link
Member

cantino commented Mar 30, 2016

Looks good, thanks!

@cantino cantino merged commit 99e709f into huginn:master Mar 30, 2016
@Jngai Jngai deleted the flightapi branch March 30, 2016 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants