Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the log format for Dry Run #1386

Merged
merged 3 commits into from Apr 5, 2016
Merged

Simplify the log format for Dry Run #1386

merged 3 commits into from Apr 5, 2016

Conversation

knu
Copy link
Member

@knu knu commented Mar 29, 2016

  • Omit the severity initial and progname
  • Show the elapsed time in HH:MM:SS instead of full date-time
    2016-03-29 18 56 22

@knu
Simplify the log format for Dry Run
cb6f77f 
- Omit the severity initial and progname
- Show the elapsed time in HH:MM:SS instead of full date-time
@knu
Copy link
Member Author

knu commented Mar 29, 2016

Idea taken from #1371 by @thiagotalma.

@cantino
Copy link
Member

cantino commented Mar 30, 2016

Maybe @dry_run_started_at if it'll bleed out of the dry_run as an instance variable. Otherwise, looks good to me!

@knu knu merged commit 90cd771 into master Apr 5, 2016
@knu
Copy link
Member Author

knu commented Apr 5, 2016

Good point, I renamed it and got this PR merged, thanks!

@thiagotalma
Copy link
Contributor

@knu What do you think of even more dry?

[00:00:00] [INFO] Dry Run started
[00:00:00] [INFO] Fetching https://graph.facebook.com/.....

@knu knu deleted the simplify_log_format branch September 9, 2017 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knu @cantino @thiagotalma