PostAgent: allow sending arbitrary string data #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Change `content_type` to `xml` to send XML, where the name of the root element may be specified using `xml_root`, defaulting to `post`. | ||
|
|
||
| When `content_type` containts a [MIME](https://en.wikipedia.org/wiki/Media_type) type, the interpolated value of `payload` will be send as a string in the HTTP body message and `content_type` will be set as the `Content-Type` HTTP header. |
There was a problem hiding this comment.
Minor edit:
When `content_type` contains a [MIME](https://en.wikipedia.org/wiki/Media_type) type, and `payload` is a string, its interpolated value will be sent as a string in the HTTP request's body and the request's `Content-Type` HTTP header will be set to `content_type`.
|
Nice! |
When `content_type` contains a MIME type and `payload` is not a Hash the string in `payload` will be send as the HTTP body and `content_type` is send as the `Content-Type` header. huginn#1361
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
content_typecontains a MIME type andpayloadis not a Hash the string inpayloadwill be send as the HTTP body andcontent_typeis send as theContent-Typeheader.#1361