Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#141 change delayed_job.handler to mediumtext (16MB) like event.payload #152

Merged
merged 1 commit into from
Jan 31, 2014

Conversation

Alex-Ikanow
Copy link
Contributor

This isn't a complete fix because if the event.payload is (say) exactly
16MB then the handler will be >16MB and the same problem will occur.

I'll push this in for now though, in practice it means it's much less
likely to occur.

….payload

This isn't a complete fix because if the event.payload is (say) exactly
16MB then the handler will be >16MB and the same problem will occur.

I'll push this in for now though, in practice it means it's much less
likely to occur.
cantino added a commit that referenced this pull request Jan 31, 2014
#141 change delayed_job.handler to mediumtext (16MB) like event.payload
@cantino cantino merged commit b16f105 into huginn:master Jan 31, 2014
@cantino
Copy link
Member

cantino commented Jan 31, 2014

Thanks!

@Alex-Ikanow
Copy link
Contributor Author

Should you find yourself anywhere near the payload->handler code at some point, you might want to check the ==16MB payload code - does the handler get corrupted by the preamble/postamble? (If so it's probably as simple as actually limiting the payload to 16MB - delta). Do you want me to keep the parent issue open so one of us can address that (probably small) hole at some point, close it, or create another?

@Alex-Ikanow Alex-Ikanow deleted the update_handler_text_size branch January 31, 2014 21:37
@cantino
Copy link
Member

cantino commented Jan 31, 2014

That's a good point. You could make a new issue for it.

On Fri, Jan 31, 2014 at 1:32 PM, Alex notifications@github.com wrote:

Should you find yourself anywhere near the payload->handler code at some
point, you might want to check the ==16MB payload code - does the handler
get corrupted by the preamble/postamble? (If so it's probably as simple as
actually limiting the payload to 16MB - delta). Do you want me to keep the
parent issue open so one of us can address that (probably small) hole at
some point, close it, or create another?

Reply to this email directly or view it on GitHubhttps://github.com//pull/152#issuecomment-33844555
.

DataMinerUK pushed a commit to DataMinerUK/huginn that referenced this pull request Oct 6, 2014
huginn#141 change delayed_job.handler to mediumtext (16MB) like event.payload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants