Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images: fix sudo swallowing env variables #1560

Merged
merged 1 commit into from
Jun 24, 2016

Conversation

dsander
Copy link
Collaborator

@dsander dsander commented Jun 23, 2016

Adds the -E argument to sudo calls which passes the environment to the called command. Ensures env variables which are not defined with default in .env.example are available in Huginn.
Fixes encoding issue when loading agent gems which contain non ASCII characters.

Adds the -E argument to sudo calls which passes the environment to the called command. Ensures env variables which are
not defined with default in .env.example are available in Huginn.
Fixes encoding issue when loading agent gems which contain non ASCII characters.
@dsander
Copy link
Collaborator Author

dsander commented Jun 23, 2016

Forgot to mention, it can be tested with:

docker run -it -e ADDITIONAL_GEMS="huginn_nlp_agents(github: kreuzwerker/DKT.huginn_nlp_agents),huginn_readability_agent(github: kreuzwerker/DKT.huginn_readability_agent),huginn_website_metadata_agent(github: kreuzwerker/DKT.huginn_website_metadata_agent)" -p 3000:3000 huginnbuilder/huginn:pr-1560

@dsander dsander closed this Jun 23, 2016
@dsander dsander reopened this Jun 23, 2016
@dsander dsander closed this Jun 23, 2016
@dsander dsander reopened this Jun 23, 2016
@dsander dsander closed this Jun 23, 2016
@dsander dsander reopened this Jun 23, 2016
@dsander dsander closed this Jun 23, 2016
@dsander dsander reopened this Jun 23, 2016
@cantino
Copy link
Member

cantino commented Jun 24, 2016

Makes sense to me, but I'm still not on the Docker train yet :)

@dsander dsander closed this Jun 24, 2016
@dsander dsander reopened this Jun 24, 2016
@dsander dsander closed this Jun 24, 2016
@dsander dsander reopened this Jun 24, 2016
@dsander
Copy link
Collaborator Author

dsander commented Jun 24, 2016

Thanks for giving it a look and sorry for the open/close spam, the pull request status updates now finally have the correct link to the build :)

@dsander dsander merged commit 923d6d0 into huginn:master Jun 24, 2016
@dsander dsander deleted the docker-images-agent-gems branch June 24, 2016 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants