Attribute Difference Agent #1572
Conversation
|
Awesome @lloydpick, this looks like a useful addition to Huginn. Thanks, and welcome! |
|
|
||
| private | ||
|
|
||
| def handle(opts, event = nil) |
There was a problem hiding this comment.
Probably don't need the = nil part, since the attribute is always provided.
lloydpick
force-pushed
the
difference-agent
branch
from
11a337e
to
a289d80
Compare
|
Changes made |
|
|
||
| def handle(opts, event) | ||
| attribute = opts['attribute'] | ||
| attribute_value = event.payload[attribute].nil? ? 0 : event.payload[attribute] |
There was a problem hiding this comment.
Would it be an option to use either JSONPath or Liquid to access the attribute?
There was a problem hiding this comment.
Ok, i'll need to go find an example of that, but sure.
There was a problem hiding this comment.
Oh, I just noticed you are already calling interpolated(event) in receive, so using liquid to modify the attribute based on the incoming event would already work, but one could not access values nested in the received event object.
You could change the attribute option key to value and directly use that interpolated result, this would allow the user to set it to {{data.value}}, interpolated({data: {value: 6}}) would then return {value: "6"}.
lloydpick
force-pushed
the
difference-agent
branch
from
a289d80
to
5dcc6ab
Compare
|
ok, JSON path support has been added. I've also taken out the BigDecimal stuff after running into some weird edge cases, just gone back to floats and rounding which can be customised. |
|
That looks like a neat combination of both worlds to me, maybe you could note that all configuration options will be liquid interpolated based on the incoming event? |
|
Looks great! |
lloydpick
force-pushed
the
difference-agent
branch
from
5dcc6ab
to
23ce4b2
Compare
|
Note added |
|
Awesome, thanks @lloydpick! |
Hi,
I wanted to have the ability to enrich an event with a comparison of events, e.g. the last received value was X, what is the integer/decimal difference or percentage change when compared to the new event value Y.
Wrote this agent because I couldn't really find one that did what I wanted. I'm not sure if I could have achieved the the same outcome with some agent that already exists? I've not been using Huginn for too long, but decided to write this anyway, it let me learn how to write agents.
Code and passing tests are attached.
Cheers