Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jsonpath to jsonpathv2. #1596

Merged
merged 1 commit into from Jul 24, 2016
Merged

Updated jsonpath to jsonpathv2. #1596

merged 1 commit into from Jul 24, 2016

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Jul 22, 2016

Update reasons:

@cantino
Copy link
Member

cantino commented Jul 22, 2016

Thanks @Skarlso!

One question: which license is https://github.com/joshbuddy/jsonpath under? We should make sure it's under a permissive license.

Edit: looks like MIT, so that's good. I wish it had an actual copy of the LICENSE, though.

@cantino
Copy link
Member

cantino commented Jul 22, 2016

I assume our ENV['ALLOW_JSONPATH_EVAL'] still works and defaults to false?

@Skarlso
Copy link
Contributor Author

Skarlso commented Jul 23, 2016

Hey, @cantino!
He is under MIT. So we should be fine.

Yes everything should still work. :-)

@dsander
Copy link
Collaborator

dsander commented Jul 23, 2016

Looks good to me, great to see the code maintained again!

@Skarlso
Copy link
Contributor Author

Skarlso commented Jul 24, 2016

Thanks. :-) I hope I'll be able to do something awesome with it! :-)

@cantino
Copy link
Member

cantino commented Jul 24, 2016

@Skarlso You might want to add an actual MIT LICENSE file to the repository with his name on it (and your's?), but I'm comfortable since he had MIT in the gemspec. Thanks for doing this!

@cantino cantino merged commit 6b751fe into huginn:master Jul 24, 2016
@Skarlso
Copy link
Contributor Author

Skarlso commented Jul 24, 2016

@cantino sure, I'll add that to make sure everything is by the books. Yw. I'll hope I can contribute more later on. :-)

@cantino
Copy link
Member

cantino commented Jul 24, 2016

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants