Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option in .env for allow_eval to be activated in jsonPath #177

Closed
wants to merge 2 commits into from

Conversation

snicker
Copy link
Contributor

@snicker snicker commented Mar 7, 2014

No description provided.

########################
# Various Settings #
########################
ALLOW_EVAL=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it ALLOW_JSONPATH_EVAL. Did you test it and it works well for you?

@snicker
Copy link
Contributor Author

snicker commented Mar 7, 2014

actually, filtering does not appear to be functional in the Ruby implementation of jsonPath...

Evaluating similar data with http://ashphy.com/JSONPathOnlineEvaluator/ gives the correct results, but using the same path expression generates errors like this:

Exception during check: undefined method `<' for nil:NilClass -- ["/usr/local/rvm/gems/ruby-1.9.3-p484@huginn/gems/jsonpath-0.5.3/lib/jsonpath/enumerable.rb:110:in `eval'", "/usr/local/rvm/gems/rub...

@snicker
Copy link
Contributor Author

snicker commented Mar 7, 2014

bleh. needs more investigation, will try to look into it this weekend

@snicker
Copy link
Contributor Author

snicker commented Mar 8, 2014

There we go!

@cantino
Copy link
Member

cantino commented Mar 9, 2014

What was the problem?

@snicker
Copy link
Contributor Author

snicker commented Mar 10, 2014

Hrm, jsonPath still doesn't seem to be working. Need to try the ruby gem by itself I think. But the env variable name is changed now

@cantino
Copy link
Member

cantino commented Mar 11, 2014

Yea, I'm curious what the raw behavior of the gem is.

@cantino
Copy link
Member

cantino commented Apr 17, 2014

@snicker What should we do with this?

@snicker
Copy link
Contributor Author

snicker commented Apr 17, 2014

Hm... not sure what caused the failing build. All this does is enable the option for allowing the JSONPath eval in the .env, I'd guess that it's safe to merge and doesn't need any specs. The issues I was experiencing seem to be related to the gem itself and need some more investigation (that I haven't done)

Do with it what you will...

@cantino
Copy link
Member

cantino commented Apr 18, 2014

Trying a rebuild (and some comments) in #229. Thanks @snicker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants