Google Flights agent - Add support for choice of carrier/alliance #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2017 14:56
Defaults set to blank and properly ignored by the api - does not create any backward compatibility issues.
cantino
reviewed
Jan 21, 2017
|
|
||
| The `origin` and `destination` options require an [airport code](http://www.expedia.com/daily/airports/AirportCodes.asp). | ||
|
|
||
| All the default options must exist. For `infantInSeatCount`, `infantInLapCount`, `seniorCount`, and `childCount`, leave them to the default value of `0` if you do not need them. | ||
|
|
||
| Make sure `date` and `return_date` is in this date format: `YYYY-MM-DAY`. | ||
| Make sure `date` and `return_date` is in this date format: `YYYY-MM-DAY`. You can use liquid formatting to dynamically assign a date in the future (i.e. 7 days from time of run). |
There was a problem hiding this comment.
Nice idea about the future dating. Maybe include an example of this?
|
|
||
| You can choose one way tickets only by setting `roundtrip` to `false`. | ||
|
|
||
| You can limit to specific airlines using the permittedCarrier option and the two-letter IATA airline codes of choice. [https://en.wikipedia.org/wiki/List_of_airline_codes](https://en.wikipedia.org/wiki/List_of_airline_codes). |
There was a problem hiding this comment.
Can you include more than one? If so, in what format?
|
|
||
| You can choose one way tickets only by setting `roundtrip` to `false`. | ||
|
|
||
| You can limit to specific airlines using the permittedCarrier option and the two-letter IATA airline codes of choice. [https://en.wikipedia.org/wiki/List_of_airline_codes](https://en.wikipedia.org/wiki/List_of_airline_codes). | ||
|
|
||
| You can alternately limit your search to specific airline alliances among the three Google-recognized ones. |
There was a problem hiding this comment.
Maybe add: "with the alliance option`"
As per @cantino's suggestions.
|
Thanks for the feedback @cantino. I've updated w/ your suggestions. |
a10kiloham
changed the title
cantino
reviewed
Jan 31, 2017
|
|
||
| The `origin` and `destination` options require an [airport code](http://www.expedia.com/daily/airports/AirportCodes.asp). | ||
|
|
||
| All the default options must exist. For `infantInSeatCount`, `infantInLapCount`, `seniorCount`, and `childCount`, leave them to the default value of `0` if you do not need them. | ||
|
|
||
| Make sure `date` and `return_date` is in this date format: `YYYY-MM-DAY`. | ||
| Make sure `date` and `return_date` is in this date format: `YYYY-MM-DAY`. You can use liquid formatting to dynamically assign a date in the future. For example to set the departure date 21 days from today, you'd use {% assign current_date = 'now' | date: '%s' %}{{current_date | plus: 1814000 | date: '%Y-%m-%d'}} |
There was a problem hiding this comment.
Can you put backticks (`) around the example, so it shows up as code?
|
Sorry for the delay, just one more small change :) |
|
fixed :) |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults set to blank and properly ignored by the api - does not create any backward compatibility issues.