Close #1914 - remove 'become user' if deactivated user #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket -- huginn#1914 Testing -- Local huginn setup About -- Switching as admin to a user is broken if the user is deactivated. This code makes the 'Become User' buttons invisible if the user to be impersonated is deactivated. The buttons used to be visible on: * /admin/users * /admin/users/XX/edit Bonus: removes the 'Become User' button from the 'Edit Users' page if we are the edited `current_user`.
|
Thanks @aeter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket -- #1914
Testing -- Local huginn setup
About --
Switching as admin to a user is broken if the user is deactivated.
This code makes the 'Become User' buttons invisible if the user to
be impersonated is deactivated. The buttons used to be visible on:
Bonus: removes the 'Become User' button from the 'Edit Users' page
if we are the edited
current_user.