initial version of astronomy agent

[qedi-r]

Agent that pulls the Weather Underground API to look for sunrise/sunset/moonrise/moonset and create events based on those times.

[cantino]

Nice @qedi-r!

Two things:

1. can you add a spec?
2. can you extract the Weather Underground behavior from this and the WeatherAgent into a shared Concern like this one: https://github.com/cantino/huginn/blob/master/app/concerns/twitter_concern.rb (this has a nice benefit of allowing support for credentials)

[qedi-r]

Yes, I was going down that road a bit, but it's easier said than done for using said concern in WeatherAgent.

I'm not sure how we can optionally include the weather underground concern or a pending forecastio concern without including both. This would run into issues if we wanted to, say, validate that the api key worked in the concern by testing the service. If we blindly include both concerns, one validation would fail necessarily.

Any thoughts on how this would be done for the current version of the Weather Agent?

[cantino]

Yea, maybe since Wunderground already has a good gem, it's not worth it. You could modify WeatherAgent as follows:

    def api_key
      if options['api_key'].present? && options['api_key'] != "your-key"
        options['api_key']
      else
        credential("#{service}_api_key")
      end
    end

    def key_setup?
      api_key.present?
    end

    ....

    def wunderground
      Wunderground.new(api_key).forecast_for(location)['forecast']['simpleforecast']['forecastday'] if key_setup?
    end

    def forecastio
      if key_setup?
        ForecastIO.api_key = api_key
        lat, lng = location.split(',')
        ForecastIO.forecast(lat,lng)['daily']['data']
      end
    end

and then you could just repeat the api_key and wunderground methods in your agent as well, so that you get the same behavior. These two could also be pulled into a Concern, but it might not be worth it.