New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenarios [work in progress] #325
Conversation
cantino
commented
May 15, 2014
- Add the concept of Scenarios (Agent Groups)
- Allow Scenarios to be exported as JSON dumps
- Allow Scenarios to be imported
- Repeated import of the same Scenario should offer to update the existing one
- Show visual diff when the existing Scenario has been edited
- Diff options editor
…to scenarios, edit scenarios, and view scenarios. next step: import and export
👍 |
Conflicts: app/assets/stylesheets/application.css.scss.erb app/views/agents/index.html.erb app/views/agents/show.html.erb
Changes Unknown when pulling b25c38c on scenarios into * on master*. |
…Scenario guid is now generated and copied to export, as well as a source link when public
Okay, Scenario creation and management is getting close to done. You can also export a JSON serialization of a Scenario. Next step is allowing import! |
Excited!! :3 |
@dsander @alias1 @Anyone-else: This is very close to done. I'd love it if you could play with it, and perhaps offer a code review! |
Glad you like it! Thanks for the suggestions; I'll integrate them and update the PR soon. I'm also changing a bit about how the import works with a differential view, so may want a second code review. :) |
…ing ones; next step is better UI
I was trying this out in combination with the new services and we probably somehow need to handle them when importing a agents that require a service to be set. Maybe show some services dropboxes in the second import step? Initially i was thinking we could merge the scenarios and services together but it's probably easier to merge one and adjust the other to work with it, right? |
Just cheering your work - very excited for this! |
Okay, I think this is ready to merge! I'll continue to test it on my installation for a day or two, then merge it. If anyone else could test it too, that'd be great! |
Yeah I too think it is good to merge, even if there are undiscovered issues it will not effect the base functionality of current instances. |
I'll do some testing tomorrow- excited to try them. |
Awesome, thanks! I'll merge shortly @kprentiss. One follow-up will be to ensure all agents that use api_keys have |
Sweet. Wife's out of town. All afternoon to play : ) |
How'd it go @kprentiss? |
Okay, MERGED! |
Any documentation on this yet? Guess I'll just take a run at it. How do existing installations migrate over? |
Not yet. Play with it and let me know what you think! You can import and export. Maybe to gists sometime soon as well. |
Random sidethought (not sure of how useful, but figured i'd tack it on here): Ability to have scenarios use/embed other scenarios. This would probably have to tie in with #390 to be done in a nice way (so it loads the 'sub-scenario' from the url on the directory site. Almost getting into a Gemfile style dependencies thing, especially when agents become seperated, they could be specified (with versions?) in the scenario file too. |
Finally got this running on my deployment, it's awesome! Definitely for organization. Following up on what @alias1 says above, it would be great if Scenarios could be treated in a similar way to how Agents are now. A Scenario should be able to specify one agent as an output endpoint and one agent as an input endpoint and also specify sources (which could be an Agent or another Scenario). For instance, while organizing my existing agents into Scenarios, I have something that I call "OutputPipeline":
Currently,
|
Scenarios [work in progress]