TwitterUserAgent Tweaks

[0xdevalias]

Solves #357 #359

[coveralls]

Coverage decreased (-0.11%) when pulling 370297c on alias1:twitteruseragent-tweaks into 43d0256 on cantino:master.

[coveralls]

Coverage decreased (-0.11%) when pulling 2eee88e on alias1:twitteruseragent-tweaks into 43d0256 on cantino:master.

[cantino]

It might be present but "false". I'd suggest

def include_retweets?
  options[:include_retweets] != "false"
end

[0xdevalias]

That's probably a cleaner way than what I have, though same outcome.

Edit: In fact, by that regard, could I not just use the following?

def include_retweets?
  !!options[:include_retweets]
end

Edit2: Nevermind, I can't because of the default being true. Done.

[cantino]

You should add a spec that shows it skipping older tweets. Let me know if you need assistance!

[0xdevalias]

I was originally going to write a spec for that, but then I couldn't think of a nice way to do it (since the boilerplate in the 'before' clause doesn't really apply for this test, so I didn't bother.

Will make an attempt at it now, but would be happy to hear a 'best practice' way to do it.

Edit: How's that?

[coveralls]

Coverage decreased (-0.02%) when pulling fe75d6b on alias1:twitteruseragent-tweaks into 43d0256 on cantino:master.

[coveralls]

Coverage increased (+0.02%) when pulling 4b48a6e on alias1:twitteruseragent-tweaks into 43d0256 on cantino:master.

[coveralls]

Coverage increased (+0.02%) when pulling 1bf0e3b on alias1:twitteruseragent-tweaks into 43d0256 on cantino:master.

[cantino]

Looks good to me @alias1. If you're happy with it and have manually tested it with some Twitter data, go ahead and merge. Nice work!

[cantino]

@alias1 are you happy with this?

[0xdevalias]

Been a bit busy with life priorities, but yup, happy with it and merged :)