New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of Pingdom Agent. Grabs Pingdom checks to pass along to other agents. #369
base: master
Are you sure you want to change the base?
Conversation
@viable-hartman Sounds cool! |
There is always a way; I'll help look into it in my spare time. |
@alias1 @viable-hartman |
@@ -64,6 +64,9 @@ gem 'wunderground', '~> 1.2.0' | |||
gem 'forecast_io', '~> 2.0.0' | |||
gem 'rturk', '~> 2.12.1' | |||
|
|||
# Required for the pingdom agent | |||
gem 'rest-client', '~> 1.6.7', require: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can, let's use faraday
or typhoeus
instead and not add a new dependency.
Thanks @viable-hartman! This is a cool idea for an Agent, and I like your specs! Couple things:
|
I think its a good idea to use the liquid filter. @viable-hartman If you want to go with it you need to include LiquidInterpolatable to you agent |
If you merge in master, you should be able to just use |
Hey @viable-hartman, are you still planning to work on this? If not, I might try to get it updated. |
7f186ad
to
9113fa5
Compare
I use the memory hash to store the last Pingdom check and only create events if the status has changed from the previous check in. I've been running this internally for the last couple days without any issue, and its been updating agents it sources perfectly.
I've provided real data from my Pingdom queries in the rspec, so all should be well.