Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove itself from ".bash_history" #44

Closed
aik099 opened this issue Feb 9, 2019 · 4 comments
Closed

Remove itself from ".bash_history" #44

aik099 opened this issue Feb 9, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@aik099
Copy link

aik099 commented Feb 9, 2019

I'm seeing #mcfly: entries, when using history command.

Since McFly does regenerate .bash_history file used by history command, then it likely could remove mentions to itself from there.
@aik099 aik099 mentioned this issue Feb 9, 2019
Closed
@cantino
Copy link
Owner

cantino commented Feb 13, 2019

Covered by #43.

@cantino cantino closed this as completed Feb 13, 2019
@cantino
Copy link
Owner

cantino commented Feb 23, 2019

Sorry, my mistake. This PR can be fixed, #43 is actually much harder.

@cantino cantino reopened this Feb 23, 2019
@cantino cantino added the enhancement New feature or request label Feb 23, 2019
@cantino
Copy link
Owner

cantino commented Feb 23, 2019

I actually don't see any occurrences of #mcfly: when I run history. Are you still seeing these?

@aik099
Copy link
Author

aik099 commented Feb 25, 2019

The problem is gone. I guess it was happening, because hook from PROFILE_COMMAND wasn't invoked.

@aik099 aik099 closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cantino @aik099