New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explorer integration #77
Comments
This is a bit of a can of worms, to be honest. Firstly, there's no way to have checkboxes available in the explorer context menu as you describe. There would have to be a 'Share via Syncthing' option, which would launch / restore SyncTrayzor and cause it to display some dialog, where you can select which devices to share the folder with. At this point, we're starting to duplicate UI that's already in Syncthing. Let's open the can...
So, would a better option be to open the 'Add Folder' UI that Syncthing already provides, with the folder path pre-populated? That would be nicer, but also pretty hard - Syncthing's UI is a website, and while I can do evil stuff to manipulate it inside SyncTrayzor, I'm relying on Syncthing implementation details which could change at any time, and break SyncTrayzor (this already happened with the 'Open Folder' button in the UI). Lastly, I'm not sure useful this would actually be. My understanding is that the common use-case is that the user adds several folders, then uses those from that point forwards. Syncthing doesn't offer Dropbox-like functionality where a link to a specific file can be generated and handed out to anybody |
Gah :( (Slightly inelegant alternative -- set the menu item label to "start sharing with [person]" / "stop sharing with [person]")
GUID for the unique ID, and folder name for the non-unique friendly name that the user can change later if they wish (syncthing doesn't support this yet, there's a discussion about it: https://forum.syncthing.net/t/friendly-names-for-shared-folders/2477/10 / and a syncthing feature request: syncthing/syncthing#966)
The defaults seem non-harmful and easy to change, so defaults should be fine
Also gah :( This seems like an implementation detail of the current version of syncthing rather than a fundamental design problem, at least...
That's slightly less slick, but seems reasonable, if we can get syncthing to provide a sane "prompt the user to add folder [blah], or configure that folder if it's already being shared" API.
Ad-hoc sharing is indeed uncommon - but ad-hoc sharing is currently a massive pain in the ass to set up. I suspect that if it were as easy as "right click -> share with [person] -> job done", it would become common :) |
I'm tempted to park this until the discussion around friendly folder names is resolved. If this does make it in, I'd also be tempted to disable it by default, and allow it to be enabled in the settings, since it is likely to be an uncommon use-case and programs adding themselves to my explorer context menu just pissed me off :) |
Yeah, without friendly folder names this would be annoying to use Have it as an option in the installer version? That seems to be what most not-rude apps with right click integration do; having it only available in the preferences menu, off by default, is equivalent to not existing for most people v_v |
+1 from me, I like it! 😃 |
A better way to do this would be to show the 'Add Folder' dialog, and pre-populate the 'Folder Path' input |
I wasn't sure if I should open a new issue but I think one thing that would be cool is a context menu in Windows to pause/unpause a folder syncing. For example, if I am about to make a lot of changes to a shared folder, I don't want ST to start syncing so I would like to pause it. Right now I have to open ST and that works but being able to do from the context menu would be easier. Even better if SyncTrayzor had a "pause for X minutes/hours" option. I know ST doesn't have it so SyncTrayzor would have to time it. I know there is now way for explorer context menu to know if a folder is shared or not so the option would show up for all folders and it would be up to the end-user to use it on folders that are being shared. |
I'd welcome contributions! |
Right click on folder -> "Share via Syncthing" menu item is visible -> hovering over that menu item, a submenu appears with a bunch of checkboxes for each device that syncthing knows about.
(Possibly this could be an entirely separate thing to SyncTrayzor - but IMO making synctrayzor "easy to use windows integration" gives it a lot more value than being just a systray icon and nothing else)
The text was updated successfully, but these errors were encountered: