Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report #7

Closed
ChenShuwei1001 opened this issue Aug 15, 2021 · 0 comments
Closed

Bug report #7

ChenShuwei1001 opened this issue Aug 15, 2021 · 0 comments

Comments

@ChenShuwei1001
Copy link

ChenShuwei1001 commented Aug 15, 2021

A bug hard to notice:
in 'basicsr/models/crop_validation.py', the beginning of method 'forward_crop', two assert statements are used:
assert lq_size == 64 or 48, "Default patch size of LR images during training and validation should be {}.".format(lq_size)
assert overlap == 16 or 12, "Default overlap of patches during validation should be {}.".format(overlap)
you should insteadly use
assert lq_size == 64 or lq_size ==48, "Default patch size of LR images during training and validation should be {}.".format(lq_size)
assert overlap == 16 or lq_size ==12, "Default overlap of patches during validation should be {}.".format(overlap)
because origin statement will be explained as assert (lq_size==64) or (48), which is always True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant