Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate async functions into modules #748

Closed
tejasmanohar opened this issue Apr 20, 2015 · 5 comments
Closed

Separate async functions into modules #748

tejasmanohar opened this issue Apr 20, 2015 · 5 comments
Labels

Comments

@tejasmanohar
Copy link

I want to hear from the community on this one. I've seen a lot of modules that are basically individual functions from async published as modules. To avoid this redundancy, what do you think about separating each async function into separate modules?

@aearly
Copy link
Collaborator

aearly commented Apr 20, 2015

Seems like #720 is a prereq. I like the idea, it's just a lot of work to set something like that up and maintain it.

Lodash publishes as a single module and as an ecosystem of modules. It's successful at this mainly because its maintainer works on it nearly full time. Caolan hasn't been around for almost a year. lodash-cli is a huge piece of software.

I like that there already are a lot of modules on npm that are just a single function from async, like each-async and async-reduce. Not very discoverable, but they are there.

@aearly aearly added the feature label May 19, 2015
@aearly
Copy link
Collaborator

aearly commented Jun 2, 2015

Closing this for now. Maybe we can convince @jdalton to modularize lodash-cli's secret sauce. ;)

@aearly aearly closed this as completed Jun 2, 2015
@jdalton
Copy link
Contributor

jdalton commented Jun 2, 2015

It's successful at this mainly because its maintainer works on it nearly full time.

Naw, just a little bit each day. That little bit adds up though : P

FWIW I create the custom build in less than a month back in 2012 not working on it every day. I think it's something you all could totally tackle.

@aearly
Copy link
Collaborator

aearly commented Jun 2, 2015

I'd like to learn more about how lodash-cli works, but the 3000 line source is a bit... daunting. Any guidance?

If I'm going to take a day to figure out how it works, I might as well take the time to also factor it into comprehensible chunks -- would that be welcome?

@jdalton
Copy link
Contributor

jdalton commented Jun 2, 2015

I might as well take the time to also factor it into comprehensible chunks -- would that be welcome?

Totally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants