Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle org features downgrades #1578

Merged
merged 18 commits into from
Apr 12, 2021
Merged

fix: handle org features downgrades #1578

merged 18 commits into from
Apr 12, 2021

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Apr 12, 2021

No description provided.

# Conflicts:
#	internal/api/authz/token.go
#	internal/api/grpc/admin/features.go
#	internal/api/grpc/features/features.go
#	internal/auth/repository/eventsourcing/handler/handler.go
#	internal/authz/repository/eventsourcing/eventstore/token_verifier.go
#	internal/command/features_model.go
#	internal/command/iam_features.go
#	internal/command/iam_features_model.go
#	internal/command/org_features.go
#	internal/command/org_features_model.go
#	internal/command/org_policy_login.go
#	internal/command/setup_step12.go
#	internal/domain/features.go
#	internal/features/model/features_view.go
#	internal/features/repository/view/model/features.go
#	internal/repository/features/features.go
#	proto/zitadel/admin.proto
#	proto/zitadel/features.proto
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1578 (30ce44c) into main (2e30a6d) will increase coverage by 0.72%.
The diff coverage is 67.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
+ Coverage   44.36%   45.08%   +0.72%     
==========================================
  Files         527      527              
  Lines       22451    22663     +212     
==========================================
+ Hits         9960    10218     +258     
+ Misses      11486    11393      -93     
- Partials     1005     1052      +47     
Impacted Files Coverage Δ
internal/command/org_idp_config.go 43.54% <0.00%> (-1.46%) ⬇️
internal/command/org_features.go 66.18% <64.64%> (+66.18%) ⬆️
internal/command/org_policy_password_complexity.go 67.44% <72.72%> (+1.24%) ⬆️
internal/command/org_policy_login_factors_model.go 85.29% <74.13%> (-14.71%) ⬇️
internal/command/org_policy_login.go 65.67% <76.74%> (+4.17%) ⬆️
internal/command/org_policy_label.go 69.01% <78.94%> (+1.74%) ⬆️
internal/command/iam_features.go 7.89% <0.00%> (+7.89%) ⬆️
internal/command/iam_converter.go 100.00% <0.00%> (+13.33%) ⬆️
internal/command/iam_features_model.go 31.25% <0.00%> (+31.25%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e30a6d...30ce44c. Read the comment docs.

@livio-a livio-a requested a review from hifabienne April 12, 2021 11:16
@livio-a livio-a marked this pull request as ready for review April 12, 2021 11:16
@hifabienne hifabienne merged commit 75d4b33 into main Apr 12, 2021
@hifabienne hifabienne deleted the feature-api-downgrades branch April 12, 2021 15:03
@fforootd
Copy link
Member

🎉 This PR is included in version 0.119.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants