fix(queries): password age policy #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulk iterates as long as new events
…st statement if it has previous sequence 0
no savepoint if noop stmt, tests for stmt handler
adlerhurst
changed the title
hifabienne
reviewed
Oct 20, 2021
| "github.com/caos/zitadel/internal/api/authz" | ||
| "github.com/caos/zitadel/internal/api/grpc/object" | ||
| policy_grpc "github.com/caos/zitadel/internal/api/grpc/policy" | ||
| mgmt_pb "github.com/caos/zitadel/pkg/grpc/management" | ||
| ) | ||
|
|
||
| func (s *Server) GetPasswordAgePolicy(ctx context.Context, req *mgmt_pb.GetPasswordAgePolicyRequest) (*mgmt_pb.GetPasswordAgePolicyResponse, error) { | ||
| policy, err := s.org.GetPasswordAgePolicy(ctx) | ||
| policy, err := s.query.MyPasswordAgePolicy(ctx, authz.GetCtxData(ctx).OrgID) |
There was a problem hiding this comment.
Should be named PasswordAgePolicyByOrgID
Comment on lines
71
to
72
| // case *proj_pb.ProjectQuery_ProjectResourceOwnerQuery: | ||
| // return query.NewProjectResourceOwnerSearchQuery(q.ProjectResourceOwnerQuery.ResourceOwner) |
| return scan(row) | ||
| } | ||
|
|
||
| var ( |
| policyEvent = e.PasswordAgePolicyAddedEvent | ||
| isDefault = true | ||
| default: | ||
| logging.LogWithFields("PROJE-stxcL", "seq", event.Sequence(), "expectedTypes", []eventstore.EventType{org.PasswordAgePolicyAddedEventType, iam.PasswordAgePolicyAddedEventType}).Error("was not an event") |
There was a problem hiding this comment.
strange error message "was not an event" but I think we have this everywhere (copy past problem)
| case *iam.PasswordAgePolicyChangedEvent: | ||
| policyEvent = e.PasswordAgePolicyChangedEvent | ||
| default: | ||
| logging.LogWithFields("PROJE-EZ53p", "seq", event.Sequence(), "expectedTypes", []eventstore.EventType{org.PasswordAgePolicyChangedEventType, iam.PasswordAgePolicyChangedEventType}).Error("was not an event") |
There was a problem hiding this comment.
same here with the error message also in the following functions
correct log message
hifabienne
approved these changes
Oct 20, 2021
|
🎉 This PR is included in version 1.47.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge after #2417