Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login names (and query) #253

Merged
merged 1 commit into from
Jun 22, 2020
Merged

fix: login names (and query) #253

merged 1 commit into from
Jun 22, 2020

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Jun 22, 2020

No description provided.

@livio-a livio-a requested a review from hifabienne June 22, 2020 06:57
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #253 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   49.10%   49.09%   -0.01%     
==========================================
  Files         186      186              
  Lines        8761     8762       +1     
==========================================
  Hits         4302     4302              
- Misses       4026     4027       +1     
  Partials      433      433              
Impacted Files Coverage Δ
internal/user/repository/view/model/user.go 37.82% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89087c...1bcd3cf. Read the comment docs.

@hifabienne hifabienne merged commit 66cca48 into master Jun 22, 2020
@hifabienne hifabienne deleted the fix-loginnames branch June 22, 2020 08:38
@github-actions
Copy link

🎉 This PR is included in version 0.32.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

livio-a added a commit that referenced this pull request Jun 23, 2020
hifabienne added a commit that referenced this pull request Jun 23, 2020
* feat: translate error messages in error interceptor

* fix: add statik import

* feat: user error msgs

* feat: add translations

* feat: add translations

* feat: add translations

* feat: add translations

* feat: add translations

* feat: add translations

* some fixes and improved error messages

* display loginname only on authReq

* fix: login names (and query) (#253)

* fix: add interceptors for console (#255)

* add interceptors for console

* add interceptors for console to env.json

* fix: query side (#257)

* fix: project by id return projectview

* fix: return always view model on query side

* fix: return always view model on query side

Co-authored-by: Fabiennne <fabienne.gerschwiler@gmail.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants