Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper error message when user (and other objects) not found #337

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Jul 3, 2020

No description provided.

@livio-a livio-a requested a review from adlerhurst July 3, 2020 07:12
@livio-a livio-a mentioned this pull request Jul 3, 2020
17 tasks
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   48.55%   48.55%           
=======================================
  Files         185      185           
  Lines        8882     8882           
=======================================
  Hits         4313     4313           
  Misses       4133     4133           
  Partials      436      436           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e2db3...f4b9695. Read the comment docs.

@livio-a livio-a requested review from hifabienne and removed request for adlerhurst July 6, 2020 08:31
@livio-a livio-a changed the title fix: proper error message when user not found by loginname fix: proper error message when user (and other objects) not found Jul 6, 2020
@hifabienne hifabienne merged commit 2663450 into master Jul 6, 2020
@hifabienne hifabienne deleted the login-invalid-username branch July 6, 2020 11:18
@github-actions
Copy link

github-actions bot commented Jul 6, 2020

🎉 This PR is included in version 0.44.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

livio-a added a commit that referenced this pull request Jul 7, 2020
* fix: proper error message when user not found by loginname

* add more not found and fix some typos
hifabienne added a commit that referenced this pull request Jul 7, 2020
…350)

* feat(login): default to user selection instead of login, take login_hint into account

* fix: proper error message when user (and other objects) not found (#337)

* fix: proper error message when user not found by loginname

* add more not found and fix some typos

* feat: usergrant (#348)

* fix: add needed permissions

* feat: search project/projectgrant user grants

* fix: no zitadel permissions

* fix: queries length

* feat: add get my password policy (#346)

* feat: add get my password policy

* fix: failed merges

* chore(deps): bump contrib.go.opencensus.io/exporter/stackdriver (#343)

Bumps [contrib.go.opencensus.io/exporter/stackdriver](https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver) from 0.13.1 to 0.13.2.
- [Release notes](https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/releases)
- [Commits](census-ecosystem/opencensus-go-exporter-stackdriver@v0.13.1...v0.13.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: remove phone (#349)

* feat: remove phone number

* feat: remove phone number tests

* feat: remove phone number tests

* fix: regenerate protos

* fix(console): distinct user grant searches and creates, project grant member edit, import cleanup (#342)

* project grant member edit

* project grant member dialog, import cleanup

* readd project roles

* user login-methods cleanup

* fix sw config, user grant context

* delete user grants, context for creation, search

* contributor box shadow

* password to detail view

* user detail notification

* lint

Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Max Peintner <max@caos.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants