Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--hdi-enable-tenant #58

Closed
andre68723 opened this issue Feb 11, 2024 · 3 comments · Fixed by #64
Closed

--hdi-enable-tenant #58

andre68723 opened this issue Feb 11, 2024 · 3 comments · Fixed by #64
Labels
enhancement New feature or request

Comments

@andre68723
Copy link

Hi Richard,

a useful addition for future cases would be to enable native tenant (on such database instances) to the service manager which is pretty straightforward

PATCH https://service-manager.cfapps.eu10.hana.ondemand.com/v1/service_instances/ Body: { "parameters": { "enableTenant": true } }

Similar to cdsua maybe

  • hdiet --hdi-enable-tenant [TENANT_ID] enable native tenant
  • hdieta enable native tenant for all hdi containers

Thanks, Andre

@rlindner81
Copy link
Contributor

Hi Andre! Native HANA tenants are SAP internal only, so we did not include them or the enablement so far... but upon more reflection, I now agree with you that there should be a command to do this properly--particularly since it is a topX requirement.

There are some subtleties that the MTX tool can do well. Most prominent, the related container bindings should be deleted before the enablement and re-created after.

For the command itself, I like the syntax: --hdi-enable-tenant [TENANT_ID], where it will enable all tenants, when no particular tenant_id is specified. Due to the binding deletion, this will be considered a "dangerous" command, with no short-form.

@andre68723
Copy link
Author

great news, one minor remark:

v1/service_bindings returns now a additional field tenantId in the credentials section.
Eventually it makes sense to add this to the table output of hdil --hdi-list.

Catch is only that the current has already a tenant_id which is a different meaning. Maybe tenantId (database)?

Bildschirmfoto 2024-02-12 um 12 23 00

@rlindner81
Copy link
Contributor

That is curious... what is this database "tenant id" used for?

@rlindner81 rlindner81 added the enhancement New feature or request label Feb 15, 2024
@rlindner81 rlindner81 mentioned this issue Feb 19, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants