Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit-logging/srv/log2restv2.js does return undefined in case of success #74

Open
soccermax opened this issue Jan 4, 2024 · 1 comment
Assignees

Comments

@soccermax
Copy link

    try {
      await _post(url, data, { headers })
    } catch (err) {
      LOG._trace && LOG.trace('error during log send:', err)
      // 429 (rate limit) is not unrecoverable
      if (String(err.response?.statusCode).match(/^4\d\d$/) && err.response?.statusCode !== 429)
        err.unrecoverable = true
      throw err
    }

--> _send does not return anything. However, the _post function returns the body in case of a successful request.
Would it be possible to return this to the caller?

@sjvans sjvans self-assigned this Jan 17, 2024
@sjvans
Copy link
Contributor

sjvans commented Feb 5, 2024

hi @soccermax

why do you need the result? the log event has no return type, hence there is no return value...

best,
sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants