feat: Add simple queries feature flag #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
patricebender,
gregorwolf,
sebastianesch,
vobu,
danjoa,
johannes-vogel and
stewsk
as code owners
patricebender
approved these changes
May 29, 2024
Merged
BobdenOs
pushed a commit
that referenced
this pull request
May 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.10.0</summary> ## [1.10.0](db-service-v1.9.2...db-service-v1.10.0) (2024-05-29) ### Added * Add simple queries feature flag ([#660](#660)) ([3335202](3335202)) </details> <details><summary>postgres: 1.9.0</summary> ## [1.9.0](postgres-v1.8.0...postgres-v1.9.0) (2024-05-29) ### Added * Add simple queries feature flag ([#660](#660)) ([3335202](3335202)) </details> <details><summary>hana: 0.5.0</summary> ## [0.5.0](hana-v0.4.0...hana-v0.5.0) (2024-05-29) ### Added * simple queries ([#654](#654)) ([ba77f9e](ba77f9e)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: sjvans <30337871+sjvans@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of SQLite the simple queries are mostly compatible. When a
booleancolumn is selected it is not considered a simple query as the result would be"true" | "false"which are both truthy.In the case of Postgres a lot of number results are numbers where strings are expected and strings where numbers are expected.