Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Issues with draftActivate #30

Open
Kkoile opened this issue Oct 18, 2023 · 2 comments
Open

Performance Issues with draftActivate #30

Kkoile opened this issue Oct 18, 2023 · 2 comments
Assignees

Comments

@Kkoile
Copy link

Kkoile commented Oct 18, 2023

We encountered severe performance issues when activating a draft with sub entities, because of change-tracking plugin.

If a composite object with multiple sub entity instances is activated, each instance is read one by one from the database. See https://github.com/cap-js/change-tracking/blob/main/lib/entity-helper.js#L34
This leads to drastic performance issues in case there are a lot of sub entity instances. We encountered this, because a customer created 1000 sub entity instances and it took around a minute to activate the composite. Without having change-tracking plugin enabled it takes a fraction of a second.

I expect that db requests are reduced as much as possible and instances of one entity are read all together instead of a single instance basis.

@nkaputnik
Copy link
Contributor

Hello Nils,
we are aware of the subsequent database reads and will try to remove this behavior in subsequent iterations.
Please be aware that this initial release is an early adoper release and should not be used yet in productive use. Our intention is to gather as much feedback as possible to validate design, performance and scope, so we will be happy to listen to all incoming feedback for the next iteration.
Since this is an open source project, you're also welcome to contribute yourself and provide solutions to such issues.

Best,
Nick

@dinurp
Copy link

dinurp commented Nov 27, 2023

Dear Nick (@nkaputnik ),
You mention that this (v 1.03) is an early adopter release. Versioning with 1.x for an early adopter release is rather misleading. Could you please mention this in the documentation and share if there are any plans to production release.
Regards,
Dinu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants