Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for this project? #59

Closed
JZubero opened this issue Jul 13, 2021 · 11 comments
Closed

Roadmap for this project? #59

JZubero opened this issue Jul 13, 2021 · 11 comments

Comments

@JZubero
Copy link

JZubero commented Jul 13, 2021

First of all, many thanks to @tafelnl for the good work on this module πŸ‘ πŸ™‡β€β™‚οΈ πŸš€ 🍻

Currently this module is probably the only reliable option, since the old Cordova module repo has already been archived and the pure web-based solutions (e.g. zxing-js) are not really suitable for Capacitor/Ionic (among other things because of the iOS WebRTC v>=14.3 issue).

We are currently using this module in a project and therefore somewhat depend on it. So it would be great to know what developments are planned, preferably with a rough timeline. Especially features like Frame in Camera view or torch integration are mission critical for us and it's not clear if or when this will be addressed.

Again, we are grateful for all the work that has already been done πŸ™ Now we just want to find out if we can stick with the module πŸ™‚

@jdiaz49
Copy link

jdiaz49 commented Jul 17, 2021

First of all, thank you very much for this excellent plugin, it has been very helpful for a feature of the app I'm working on.

Currently we need to use the flashlight and the cordova plugin I use conflicts with barcode scanner.

If this functionality of the flashlight is implemented in barcode scanner it would be excellent because it would not need another plugin.

It would be great to know when this flashlight functionality would be released to negotiate with my product owner hehehe.

Thank you very much for these wonderful plugins.

@Zwimber
Copy link

Zwimber commented Jul 23, 2021

It seems to be priority 2. I assume that means that it is on the roadmap. Not sure when it'll be completed. If you look at the mentioned pull request you can try and install that version to get it working with the flashlight.

@tafelnl
Copy link
Member

tafelnl commented Jul 24, 2021

Quick update: I updated the priority labels on the different issues. Priority 1 issues are either important or easy to fix. These will be implemented in ~1 month. Priority 2 labels I cannot say for sure now. But I'll try to fix it in ~2 months. I am very busy right now, so any help is very welcome!

@arnotixe
Copy link

If you look at the mentioned pull request you can try and install that version to get it working with the flashlight.

I'm very interested in this feature, as my users work in construction and scan stuff where lighting is poor / no lighting… Maybe not the best place to ask, but what is the best way to install the feat/torch branch via npm somehow?

I googled and found this, that kind of works:

npm install git://github.com/capacitor-community/barcode-scanner#feat/torch

Only smallish problem is it has no dist/ folder
image

Found out how to checkout the branch, build it (separately) and copy in the dist/ folder… But maybe this can be done automatically somehow?

Turns on the torch with enableTorch() in android!

Doesn't turn off with disableTorch() though, but stopScan() serves πŸ˜„

@dkliemsch
Copy link

I've just created a new PR based on the latest code from the main branch adding the ability to enable, disable and toggle the torch on both android and iOS. There is also a method to get the current torch state.
@tafelnl Would be awesome if you could find some time to have a look and maybe create a new version as installing without a new npm release is really a pain (due to the missing dist folder)

@arnotixe Just so you know: The dist folder normally gets published on npm during a new release, which is why it works if you install an official version via the npm registry. If you try to install a specific branch / PR etc. directly from github that dist folder is missing.

@ec-lmayr
Copy link
Contributor

ec-lmayr commented Sep 24, 2021

I created a PR #88 for this. Using prepare instead of prepublishOnly should allow direct installs from github.

@andreagobetti
Copy link

Hi, is there an ETA for the torch capability to be published via npm? I'm trying to add the torch branch via git to my project but it fails the dependency check...

Does this feature need more work or it's ready to be published?

Thanks!

@Pacjonek
Copy link

Pacjonek commented Dec 28, 2021

First of all, many thanks to @tafelnl for the good work on this module πŸ‘ πŸ™‡β€β™‚οΈ πŸš€ 🍻

Currently this module is probably the only reliable option, since the old Cordova module repo has already been archived and the pure web-based solutions (e.g. zxing-js) are not really suitable for Capacitor/Ionic (among other things because of the iOS WebRTC v>=14.3 issue).

We are currently using this module in a project and therefore somewhat depend on it. So it would be great to know what developments are planned, preferably with a rough timeline. Especially features like Frame in Camera view or torch integration are mission critical for us and it's not clear if or when this will be addressed.

Again, we are grateful for all the work that has already been done πŸ™ Now we just want to find out if we can stick with the module πŸ™‚

Could you elaborate why pure-web based solutions are not really suitable for Capacitor? It seems that WebRTC issue has been solved.

@thegnuu
Copy link
Collaborator

thegnuu commented Feb 7, 2022

As of now, there is no roadmap... I just became a new maintainer of this plugin and I will try to clean up things and merge the open PRs in the coming weeks.

Once I am up2date what have to be done, whats already done and not merged aso. I will try to add some sort of roadmap and plan the additionally wished features.

@jorrit
Copy link

jorrit commented Feb 7, 2022

Thanks for your effort!

@thegnuu
Copy link
Collaborator

thegnuu commented Feb 27, 2022

I was able to merge most of the open PRs today...
Still need to test all the changes next week, once this is done I will release 2.1.0.

For now I will close this issue, since there are multiple inputs/questions which makes it kinda hard for me to handle.

If i missed something here or you have missing features/questions after the 2.1.0 release please open a new issue!

Thank you guys!

@thegnuu thegnuu closed this as completed Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests