Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Electron builder configuration properties via capacitor.config.json and change build process to read them dynamically #42

Closed
coreyjv opened this issue Jul 24, 2020 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@coreyjv
Copy link
Contributor

coreyjv commented Jul 24, 2020

In doing some testing on deep linking in #36 I realized that the built app was pulling statically defined properties from the electron/package.json which is mentioned in the Quick Setup guide for Electron Builder.

I would like to see these values pulled dynamically from the capacitor.config.json at the root of the project.

So the mapping would be as follows:

Capacitor Property Electron Builder Property
appId appId
appName productName

There's likely additional properties we'd want to expose as well like Electron Builder's mac.category.

Finally I believe for deep linking to work for built application it has to be statically defined per the discussion here: electron-userland/electron-builder#1552 so I think it's worth exposing the custom protocol or scheme in the configuration and not have to modify the electron.index.ts to set it.

@coreyjv coreyjv changed the title What are the expections for developers when building the electron app? Expose Electron builder configuration properties via capacitor.config.json and change build process to read them dynamically Jul 24, 2020
@IT-MikeS
Copy link
Member

Yep most static configuration options will be in the capacitor.config come version 3 of capacitor. See ionic-team/capacitor#3141

Like the Android and iOS platforms of Capacitor, Electron will still follow the idea of not getting in the way of the normal development of that platform. So if a process is done one way in electron apps without capacitor, I don't want to make it different in the capacitor platform.

@IT-MikeS IT-MikeS added the enhancement New feature or request label Jul 24, 2020
@IT-MikeS
Copy link
Member

IT-MikeS commented Feb 3, 2021

This will be in v3

@IT-MikeS IT-MikeS added this to To do in V3 May 4, 2021
@coreyjv
Copy link
Contributor Author

coreyjv commented May 17, 2021

@IT-MikeS -- What does the solution for this look like? I wouldn't mind contributing to the feature but would like to understand what you're looking for.

Thanks!

@IT-MikeS IT-MikeS moved this from To do to In progress in V3 May 19, 2021
@IT-MikeS IT-MikeS moved this from In progress to Done in V3 Jun 22, 2021
@capacitor-community capacitor-community locked and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
V3
Done
Development

No branches or pull requests

2 participants