Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node engine restriction, but why? #6

Closed
de-dan opened this issue Oct 18, 2022 · 3 comments
Closed

Node engine restriction, but why? #6

de-dan opened this issue Oct 18, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@de-dan
Copy link

de-dan commented Oct 18, 2022

Hi. Is there a specific reason why the node engine is restricted?
I'm using node 18 and it is working fine, but the warning bugs me :)

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@capacitor-community/file-opener@1.0.1',
npm WARN EBADENGINE required: { node: '>=16.15.0 <17.0', npm: '>=8.10.0 <9.0' },
npm WARN EBADENGINE current: { node: 'v18.7.0', npm: '8.15.0' }
npm WARN EBADENGINE }

@ryaa
Copy link
Member

ryaa commented Oct 18, 2022

I tested with the above node and npm combinations and will support any issues with these specific version. Other versions may work but i can not guarantee supporting all the possible node/npm versions.
We can relax the node version to include 18.x if this works fine. Can you please create a PR? :) thank you

@ryaa ryaa closed this as completed Oct 18, 2022
@ryaa ryaa added the enhancement New feature or request label Oct 18, 2022
@de-dan
Copy link
Author

de-dan commented Oct 19, 2022

Hi @ryaa, thanks for your quick response. I raised a PR. I'm still not convinced that this is the best approach, as the restriction should come from the underlying framework (Capacitor) and this plugin should (automatically) support the same versions. But that is just my opinion :) Thanks for your work

@ryaa
Copy link
Member

ryaa commented Oct 19, 2022

as the restriction should come from the underlying framework (Capacitor) and this plugin should (automatically) support the same versions.

make sense. thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants