Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Allow expires parameter for Http.setCookie(...) #16

Closed
cuddlecake opened this issue Jun 5, 2020 · 0 comments · Fixed by #83
Closed

Allow expires parameter for Http.setCookie(...) #16

cuddlecake opened this issue Jun 5, 2020 · 0 comments · Fixed by #83
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cuddlecake
Copy link

Is your feature request related to a problem? Please describe.
As a web developer familiar with cookies, I would assume Http.setCookie() to have a parameter called expires, as opposed to ageDays.

Describe the solution you'd like
I would prefer an input option for expires to exist, instead of ageDays

Describe alternatives you've considered
Provide a helper function to calculated an appropriate ageDays value, given an expires date.

Additional context
I personally think it is more complicated to derive ageDays from expires than it is to derive expires from ageDays.

@thomasvidas thomasvidas self-assigned this Jan 19, 2021
@thomasvidas thomasvidas added the enhancement New feature or request label Jan 19, 2021
@thomasvidas thomasvidas added this to the 0.3.0 milestone Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants