Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google pay is not working on react android demo code #190

Closed
1 task
mostafa3ly opened this issue Jun 15, 2022 · 8 comments
Closed
1 task

Google pay is not working on react android demo code #190

mostafa3ly opened this issue Jun 15, 2022 · 8 comments

Comments

@mostafa3ly
Copy link

Platform

  • Android

Describe the bug
Google pay is not working on react android demo code. it logs Not implemented on device on the react android demo code

@rdlabo
Copy link
Member

rdlabo commented Jul 3, 2022

@mostafa3ly Thanks for issue.

This was CapacitorStripeProvider's bug. I fixed and released v3.8.2. Please test it.
a8ef5f4

Thanks.

@rdlabo rdlabo mentioned this issue Jul 3, 2022
1 task
@mostafa3ly
Copy link
Author

@rdlabo
This issue is not fixed yet still having Google play is not implemented on device issue.

I tested your demo code of React with out changing anything it to ensure that the issue is not from my side and it gives me the same issue.

@rdlabo
Copy link
Member

rdlabo commented Jul 19, 2022

@mostafa3ly Did you run npm install and npx cap sync ? In my device, no problem to run.

@mostafa3ly
Copy link
Author

mostafa3ly commented Jul 20, 2022

@rdlabo yes sure i run npm install then npx cap sync android without changing anything in the app and the google pay button is still dimmed.

and i see that you comment a string in strings.xml file with name stripe_account i don't know if i should replace this value and to what value.

I don't think you test this on react cause you miss @capacitor/android from your dependencies so how you could run android app without it.

note: this issue happens on REACT.

@rdlabo
Copy link
Member

rdlabo commented Jul 20, 2022

Yes, I tested on react-demo. Now, work with no problem.
Can Google Pay work on your device?

@mostafa3ly
Copy link
Author

mostafa3ly commented Jul 20, 2022

@rdlabo
yes Google pay is working on my device and i tested it on your demo hosting for web on mobile google chrome browser and it working fine.

i tried your plugin on 4 phones and all of them give the same issue.
also tested on emulator
Screenshot_20220720_135840

@rdlabo
Copy link
Member

rdlabo commented Jul 21, 2022

I put the word "React" in the title of the Demo to make sure I check it with React-Android. It is indeed working.

S__12345346
S__12345348

Are you sure you run npm install? Make sure the package version of demo/react/node_modules/@capacitor-community/stripe/package.json is 3.8.2-0 or higher.

@rdlabo
Copy link
Member

rdlabo commented Dec 19, 2022

This Issue will be closed because it has not been updated for a long time. If you encounter similar problems, please start a new Issue.

@rdlabo rdlabo closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants