Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaymentSheet Google Pay button is no longer compliant with brand guidelines #254

Closed
david-nibw opened this issue Jan 12, 2023 · 8 comments
Closed

Comments

@david-nibw
Copy link

Is your feature request related to a problem? Please describe.
Integration will not be approved because the google pay button does not meet Google's brand guidelines. This appears to be the case for Google Pay Button PaymentSheet and standalone Google Pay Button

Describe the solution you'd like
New brand guidelines are here: https://developers.google.com/pay/api/android/guides/brand-guidelines#style

Screenshots
image

@rdlabo
Copy link
Member

rdlabo commented Jan 25, 2023

Thanks issue.
I created version supporting stripe-android@20.19.0:
https://github.com/capacitor-community/stripe/tree/feat/target_33#this-is-pre-release-branch

But this require to change android/variables.gradle.This may affect other plugins.
@david-nibw Can you try?

@xras-dev
Copy link

it works but there is a delay of 15 seconds when showing the payment sheet. i dont know if its only in my device.
screenshot

@rdlabo
Copy link
Member

rdlabo commented Jan 26, 2023

I too can confirm that it appears late. This does not occur with v20.17.0, but starting since v20.18.0🤔

2023-01-26 11:35:35.364 25133-25133/io.ionic.starter W/o.ionic.starter: Method boolean androidx.compose.runtime.snapshots.SnapshotStateList.conditionalUpdate(kotlin.jvm.functions.Function1) failed lock verification and will run slower.
    Common causes for lock verification issues are non-optimized dex code
    and incorrect proguard optimizations.
2023-01-26 11:35:35.364 25133-25133/io.ionic.starter W/o.ionic.starter: Method java.lang.Object androidx.compose.runtime.snapshots.SnapshotStateList.mutate(kotlin.jvm.functions.Function1) failed lock verification and will run slower.
2023-01-26 11:35:35.364 25133-25133/io.ionic.starter W/o.ionic.starter: Method void androidx.compose.runtime.snapshots.SnapshotStateList.update(kotlin.jvm.functions.Function1) failed lock verification and will run slower.

Only the first startup is delayed, not the second or subsequent ones.

@rdlabo
Copy link
Member

rdlabo commented Jan 26, 2023

rdlabo added a commit that referenced this issue Jan 26, 2023
@rdlabo
Copy link
Member

rdlabo commented Jan 26, 2023

@xras-dev v4.1.2-1 is released. this use stripe-android@20.17.0. Please try.

@xras-dev
Copy link

v4.1.2-1 working perfect but v4.1.2 is still using stipe v20.11
Captura de pantalla 2023-01-26 a las 9 50 45

@rdlabo
Copy link
Member

rdlabo commented Feb 1, 2023

That's right. I'm wonder if it is mandatory to give the compileSdkVersion and targetSdkVersion of the project for the plugin. So this will be operated with the next tag for the time being.

@xras-dev
Copy link

xras-dev commented Feb 1, 2023

ok, good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants