Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency duplication #5

Closed
ArtturiSipila opened this issue Jan 15, 2016 · 2 comments
Closed

Dependency duplication #5

ArtturiSipila opened this issue Jan 15, 2016 · 2 comments

Comments

@ArtturiSipila
Copy link

Hey thanks for a great repo, it's very nice! Only one thing bugs me a bit. The dependencies are duplicated, one has to install same libraries in node_modules and jspm_packages. It's not a huge problem but it would be more elegant to be able to use jspm everywhere, also in testing. Do you have idea how this could be solved?

This thing could also introduce issues, in this case for example I can see that you have a different version of react in node_modules and in jspm_packages .

@capaj
Copy link
Owner

capaj commented Jan 17, 2016

yes I do. I have it solved on another project of mine. JSPM is isomorphic, so it runs in node.js as well. So running tests from JSPM dependencies is not a big problem. Will try to update the tests here with JSPM dependencies instead of NPM.

@ArtturiSipila
Copy link
Author

Ok great to hear, looking forward! I'm currently experimenting with JSPM in a react project and so far it's looking pretty good, my only issue (likely unrelated to this one) is that my tests are not able to locate sub-components with module not found errors... anyway, let's just close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants