Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending prop usage is a bit unintuitive #18

Closed
andywer opened this issue Mar 2, 2018 · 2 comments
Closed

pending prop usage is a bit unintuitive #18

andywer opened this issue Mar 2, 2018 · 2 comments
Assignees
Milestone

Comments

@andywer
Copy link

andywer commented Mar 2, 2018

Hey @capaj,
thanks for providing this useful helper.

I just used it for the first time and did a mistake, that I suppose is quite common:
then and catch props are functions returning some React node. The pending prop instead is supposed to be a React node, not a function.

I get that there is no argument to pass to pending, but it would be easier to use if they would all just take a function.

Cheers

@capaj
Copy link
Owner

capaj commented Mar 2, 2018

Hey @andywer thanks for using it! I will make it so that you can use both.
I usually just put some loading spinner into pending so that's why there wasn't an option to put a whole function in. I will add just for the sake of consistency.

@andywer
Copy link
Author

andywer commented Mar 2, 2018

Cool and thx for the ultra-quick response 😊

@capaj capaj added this to the 2.0.2 milestone Mar 2, 2018
@capaj capaj self-assigned this Mar 2, 2018
@capaj capaj closed this as completed in 659d091 Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants