Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dis-allow borrow_deref_ref with new PyO3 release #22

Closed
jvmncs opened this issue Aug 15, 2022 · 0 comments · Fixed by #25
Closed

Dis-allow borrow_deref_ref with new PyO3 release #22

jvmncs opened this issue Aug 15, 2022 · 0 comments · Fixed by #25

Comments

@jvmncs
Copy link
Member

jvmncs commented Aug 15, 2022

Per the following issues, there is a problem with PyO3's pyfunction macro triggering a faulty warning in clippy:

In #21 we force allow-ed the faulty warning. The PyO3 PR merges a fix, but it has not yet made it's way into a release. Once a new version of PyO3 has been published, we should revert the lint change we did in #21 by dis-allowing the lint warning for borrow_deref_ref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant