Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do subdirectories of "releases" have to have timestamps as names or not? #53

Closed
tjoneseng opened this issue Jun 10, 2011 · 1 comment
Closed

Comments

@tjoneseng
Copy link

The following entry appears in CHANGELOG under 2.5.0 / August 28, 2008:

Sort releases via "ls -xt" instead of "ls -x" to allow for custom release names [Yan Pritzker]

I don't know if that change was made then reverted or what, but "ls -x" is definitely being used, which does not work with non-timestamp subdirectory names (for example the "current_release" variable can be misset, leading to all sorts of mayhem).

Either that changelog entry should be removed and the official documentation should be updated to note this assumption to avoid confusion, or the change it refers to should be made in lib/capistrano/recipes/deploy.rb line 58.

@leehambley
Copy link
Member

The following entry appears in CHANGELOG under 2.5.0 / August 28, 2008:

I'm sure many things have changed, that change log entry was written before my stewardship. I'll happily consider a patch with the suitable options set (there is no one-size fits all here) … in the short term you can override the :releases

_cset(:releases) { capture("ls -x #{releases_path}", :except => { :no_release => true }).split.sort }

The file, for reference can be found here. If your note is especially about the changelog, then I refer you to the issue #88 which prompted the change. I wasn't aware that it had been explicitly, documentedly changed to ls -xt before my time. (And, as you may know the standard deploy.rb lacks tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants