Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on(:local) fails on windows #252

Closed
jarredholman opened this issue May 18, 2015 · 5 comments
Closed

on(:local) fails on windows #252

jarredholman opened this issue May 18, 2015 · 5 comments

Comments

@jarredholman
Copy link

Etc.getpwuid returns nil on windows so SSHKit::Host.new(:local) raises an exception

@leehambley
Copy link
Member

Don't use on(:local) there's no good reason not to use the standard Ruby/Rake APIs. It exists for legacy reasons, if it doesn't work on your platform please provide a patch if you can.

@leehambley
Copy link
Member

http://stackoverflow.com/a/3544741/119669 might give you a place to start.

@jarredholman
Copy link
Author

Well I am using run_locally in capistrano and this bug is preventing me from updating to the latest version.
I guess I'll try to avoid using that.

@leehambley
Copy link
Member

There's literally nothing to be gained by using run_locally(), if you're on Windows and something is unsupported, you can monkey patch it anyway, the SO link shows some ways you might work around that rather than refactoring your code. run_locally is basically no different to shelling out with Ruby http://julialang.org/blog/2012/03/shelling-out-sucks/ unless you are using the command map, and plugins, etc which essentially don't do anything locally anyway.

@mattbrictson
Copy link
Member

I think this has been fixed by #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants