Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an in memory cache. #1271

Merged
merged 2 commits into from Aug 13, 2017
Merged

Conversation

Sutto
Copy link
Contributor

@Sutto Sutto commented Jun 9, 2017

This is a WIP PR, but it's worth nothing this implements a simple, shared in memory cache.

The default file cache has a pretty serious memory leak in pull mode - Since it instantiates and loads the cache for each policy, memory grows a copy of the cache for each policy.

This uses a single shared dict, and a simpler structure, to avoid that when want a cache for the lifetime of the run but not to be persisted.

@kapilt
Copy link
Collaborator

kapilt commented Jun 10, 2017

sounds good re mem cache, although plus test. though that raises a bigger question of whats causing the extant cache to stay resident.

@kapilt
Copy link
Collaborator

kapilt commented Jun 10, 2017

extant file cache leak fix in #1281

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 3a81db9 into cloud-custodian:master Aug 13, 2017
@Sutto Sutto deleted the in-memory-cache branch November 12, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants