s3 toggle-logging action - append '/' to the default target_prefix (#1464)

[seth-carroll]

Verified the change locally

[alfredgamulo]

makes sense; LGTM

[kapilt]

hmmm.. slash here would result in double slash in keys? ie. what is the goal and effect of this change? when i did a trailing slash in inventory it had unexpected results. going through our unit tests i do see a slash on log prefixes though, just want to be clear on the reasons for the change.

[kapilt]

ah.. actual reason for change is described in #1464

[seth-carroll]

Yes, sorry - should have put that in the PR message as well. Currently the slash is missing from the prefix, so the log objects get written directly into the root of the logging destination bucket.

Example action:

    actions:
      - type: toggle-logging
        target_bucket: my-logging-bucket

Results in log objects like this:

s3://my-logging-bucket/my-source-bucket2017-08-07-17-22-28-D5813C87E6C5A11F

[kapilt]

thanks, lgtm