Support for current region in check-cloudtrail #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes check-cloudtrail able to check if the given region is covered, at all - not just via multi region. This lets us run it against individual regions to check cloud trail logging / auditing.
|
Fwiw policies take a region attribute to keep a policy region bound, added for s3. |
|
That only restricts where they're run though, right? Using this, you can run / invoke c7n with the check, and it'll only emit the account IF said account has a trail for the region at all. |
kapilt
approved these changes
Feb 27, 2017
c7n/resources/account.py
Outdated
| if self.data.get('current-region'): | ||
| current_region = session.region_name | ||
| trails = [t for t in trails if t.get('HomeRegion') == current_region or t.get('IsMultiRegionTrail')] | ||
| print(trails, current_region) |
There was a problem hiding this comment.
Ah crud! Will fix this :) good catch.
| trails = client.describe_trails()['trailList'] | ||
| resources[0]['c7n:cloudtrails'] = trails | ||
| if self.data.get('global-events'): | ||
| trails = [t for t in trails if t.get('IncludeGlobalServiceEvents')] | ||
| if self.data.get('current-region'): |
There was a problem hiding this comment.
this could use some docs in the class docstring. i do think we have other ways of getting/verifying this with the extant, but its a net win for policy authoring.
|
Let me know if the comment looks ok to you! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes check-cloudtrail able to check if the given region is
covered, at all - not just via multi region.
This lets us run it against individual regions to check cloud trail
logging / auditing.