Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with large datasets #51

Closed
robne1982 opened this issue Jul 31, 2018 · 0 comments · Fixed by #53
Closed

Error with large datasets #51

robne1982 opened this issue Jul 31, 2018 · 0 comments · Fixed by #53
Labels
bug pr_pending PR has been raised v1.1.2

Comments

@robne1982
Copy link
Collaborator

The line

totalSize <- nrow(coercedData[[1]])*ncol(coercedData[[1]]) + nrow(coercedData[[2]])*ncol(coercedData[[2]])

aims to calculate the total number of elements for comparison. However, if this results in a value outside the range of a 32-bit integer, the code errors with

Running rCompare...
Coercing input data to data.frame
Error in if (totalSize > 2e+07) { : missing value where TRUE/FALSE needed
In addition: Warning message:
In nrow(coercedData[[1]]) * ncol(coercedData[[1]]) + nrow(coercedData[[2]]) *  :
  NAs produced by integer overflow

This code is just there to warn the user about a possible long run time, so it'd be preferable to remove this rather than cause this error, although I imagine there are probably numerous ways to fix it.

@robne1982 robne1982 mentioned this issue Aug 1, 2018
7 tasks
@robne1982 robne1982 added the pr_pending PR has been raised label Aug 15, 2018
sajohnston pushed a commit that referenced this issue Aug 31, 2018
* Update rc_rCompare.R

* Create testLargeDataWarning.R

* Update testLargeDataWarning.R

* Added one more as.double

* Refactored large data warning to make it more testable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pr_pending PR has been raised v1.1.2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant