Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new plugin hook for Upgrading packages #39

Closed
fdosani opened this issue Jul 5, 2022 · 0 comments · Fixed by #40
Closed

Create a new plugin hook for Upgrading packages #39

fdosani opened this issue Jul 5, 2022 · 0 comments · Fixed by #40
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@fdosani
Copy link
Member

fdosani commented Jul 5, 2022

So currently the packages are always upgraded via pip here.

Proposal is to make this a hook, something like:

@hookspec(firstresult=True)
def run_update(python_path: str, upgrade: List):
    """Update packages from upgrade list.

    Parameters
    ----------
    python_path : str
        The path to the python executable.
    upgrade : list
        The list of packages to upgrade
   
    Raises
    ------
    RuntimeError
        Error raised if the packages cannot be updated.
    """

This directly links back to a request in the conda plugin: capitalone/edgetest-conda#30
Enabling this functionality will enable the plugin to provide a spec to upgrade via conda.

@fdosani fdosani added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Jul 5, 2022
@fdosani fdosani mentioned this issue Jul 6, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants