Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added buttons to select all or remove all columns in UI table #134

Merged
merged 10 commits into from Oct 26, 2021

Conversation

shania-m
Copy link
Contributor

closes: #61


What

  • Introduced buttons to select all columns or hide all columns in Rubicon UI experiment tables

How to Test

  • When select all columns button is clicked, all columns appear in the table
  • When clear all columns button is clicked, no columns appear in the table

@ryanSoley
Copy link
Member

looks like we're right on the edge of the test coverage threshold. the UI stuff is barely tested at all, let's just add the ui directory to the omit section of coverage.py for now. we can revisit the UI tests later

@shania-m
Copy link
Contributor Author

looks like we're right on the edge of the test coverage threshold. the UI stuff is barely tested at all, let's just add the ui directory to the omit section of coverage.py for now. we can revisit the UI tests later

done @ryanSoley

@ryanSoley
Copy link
Member

I think it wants the full path, rubicon_ml/ui. you can run python -m pytest locally to see what the coverage percentage is reporting as and to make sure it picks up the change

@ryanSoley
Copy link
Member

the functionality works perfectly! nice job! I do have a nitpick regarding the layout - I'd prefer if the "select all columns" and "clear all columns" were right aligned with the "toggle columns" buttons. so it'd be more like

[Select All] [Clear All]                       [Select All Columns] [Clear All Columns] [Toggle Columns]

if thats not a trivial change, don't spend too much time on it and we can just revisit it later. but I don't think it should be a big change

@shania-m shania-m merged commit bad4877 into main Oct 26, 2021
@shania-m shania-m deleted the 61_column_filtering branch October 26, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more column filtering control on dashboard
3 participants